Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluating swagger-ui part of application #18

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Evaluating swagger-ui part of application #18

wants to merge 19 commits into from

Conversation

iyangar
Copy link
Contributor

@iyangar iyangar commented Jul 22, 2019

No description provided.

cyenyxe
cyenyxe previously requested changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@cyenyxe cyenyxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simpler approach: https://www.47northlabs.com/knowledge-base/generate-spring-boot-rest-api-using-swagger-openapi/ Could you give it a try?

@iyangar
Copy link
Contributor Author

iyangar commented Aug 7, 2019

https://github.com/iyangar/test/tree/master/ebi/swagger/testampt2d-spec
https://github.com/iyangar/test/tree/master/ebi/swagger/testampt2dservice

@selvaebi
Copy link
Contributor

selvaebi commented Oct 1, 2019 •
edited
Loading

http://ves-hx-e9.ebi.ac.uk:8080/dev/registry/swagger-ui.html is not accessible without auth. and also please check the URLs behind proxy https://www.ebi.ac.uk/ega/ampt2d/dev/registry.

@selvaebi
Copy link
Contributor

selvaebi commented Oct 1, 2019

but behind the proxy thing you can do it in Migration ticket, please make Swagger-UI accessible to test for now.

@iyangar
Copy link
Contributor Author

iyangar commented Oct 1, 2019

#18 (comment)
Just forgot, with OpenAPI the link will be http://ves-hx-e9.ebi.ac.uk:8080/dev/registry/swagger-ui/. (From there default index.html starts)

selvaebi
selvaebi reviewed Oct 1, 2019
View reviewed changes
pom.xml Outdated
<groupId>io.springfox</groupId>
<artifactId>springfox-bean-validators</artifactId>
<version>2.8.0</version>
<groupId>org.webjars</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? as we are manually downloading and unzip in unpack goal.

@tskir tskir dismissed cyenyxe’s stale review October 4, 2019 10:51

No longer working for EMBL-EBI

tskir
tskir approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@tskir tskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good (except for the server name in YAML, which is discussed in the issue)

@iyangar
Copy link
Contributor Author

iyangar commented Oct 7, 2019

More details in the Jira Ticket

@iyangar iyangar requested a review from tskir October 7, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selvaebi selvaebi selvaebi left review comments

@tskir tskir tskir approved these changes

@cyenyxe cyenyxe cyenyxe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iyangar @selvaebi @cyenyxe @tskir