Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename binary to dynatrace-otel-collector #59

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix: Rename binary to dynatrace-otel-collector #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb80ebe
fix: Rename binary to dynatrace-otel-collector
heckelmann Sep 7, 2023
2d7958c
Merge branch 'main' into fix/binary-name
heckelmann Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ In order to remove them run `make clean-tools` or `make clean-all`.

### Building the collector

The command `make` or `make build` (the default target) will build the collector for your operating system and CPU architecture. The resulting binary will be `bin/otelcol-dynatrace`.
The command `make` or `make build` (the default target) will build the collector for your operating system and CPU architecture. The resulting binary will be `bin/dynatrace-otel-collector`.

#### Cross-compiling other architectures

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ BIN_DIR = bin
# SRC_ROOT is the top of the source tree.
SRC_ROOT := $(shell git rev-parse --show-toplevel)

BIN = $(BIN_DIR)/otelcol-dynatrace
BIN = $(BIN_DIR)/dynatrace-otel-collector
MAIN = $(BUILD_DIR)/main.go

# Files to be copied directly from the project root
Expand Down
2 changes: 1 addition & 1 deletion manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dist:
module: github.com/Dynatrace/dynatrace-otel-collector
name: otelcol-dynatrace
name: dynatrace-otel-collector
description: Dynatrace OpenTelemetry Collector Distribution
output_path: ./build
version: 0.0.1-alpha
Expand Down
4 changes: 2 additions & 2 deletions testbed/smoke/smoke_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"gopkg.in/yaml.v3"
)

var execPath = "../../bin/otelcol-dynatrace"
var execPath = "../../bin/dynatrace-otel-collector"

func TestCollectorStarts(t *testing.T) {
col := testbed.NewChildProcessCollector(testbed.WithAgentExePath(execPath))
Expand All @@ -27,7 +27,7 @@ func TestCollectorStarts(t *testing.T) {
col.PrepareConfig(string(cfg))

err = col.Start(testbed.StartParams{
Name: "otelcol-dynatrace",
Name: "dynatrace-otel-collector",
LogFilePath: "col.log",
})
require.NoError(t, err)
Expand Down