Transfer EC.Labels and EC.Annotations to the POD spec #4153
+109
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorcholski
added
bug
aorcholski
force-pushed
the
bugfix/ec-labels
branch
from
c2f26e5
to
3cc39af
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
=======================================
Coverage 64.49% 64.50%
=======================================
Files 399 399
Lines 26772 26778 +6
=======================================
+ Hits 17266 17272 +6
Misses 8145 8145
Partials 1361 1361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aorcholski
force-pushed
the
bugfix/ec-labels
branch
from
3cc39af
to
1e4fc72
Compare
aorcholski
force-pushed
the
bugfix/ec-labels
branch
from
1e4fc72
to
f037d58
Compare
aorcholski
requested review from
gkrenn,
0sewa0,
chrismuellner,
albertogdd,
waodim,
StefanHauth and
luhi-DT
| labels := maputils.MergeMap( | ||
| ec.Labels, | ||
| appLabels.BuildLabels(), | ||
| buildLabels := appLabels.BuildLabels() |
There was a problem hiding this comment.
Can we find alternative name? It's appLabels TBH.
|
|
||
| deployment := New(ec) | ||
|
|
||
| assert.Len(t, deployment.Spec.Template.Labels, 5) |
There was a problem hiding this comment.
This check a bit confusing, better IMO demonstrate that we only have default app labels.
aorcholski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Description
edgeconnect.Spec.Labelsandedgeconnect.Spec.Annotationsare applied toObjectMetaof the EC POD being created.deployment.ObjectMeta.Labels,deployment.Spec.Selectorvalues are calculated in the same way as in case of EEC/OTELC statefulset.How can this be tested?