Fix ansible-lint errors

galaxy.yml

@@ -16,5 +16,7 @@ tags:
 repository: https://github.com/Dynatrace/Dynatrace-OneAgent-Ansible
 documentation: https://docs.dynatrace.com/docs/setup-and-configuration/dynatrace-oneagent/deployment-orchestration/ansible
 build_ignore:
-  - roles/oneagent/tests
-  - roles/oneagent/examples
+  - .github
+  - .pre-commit-config.yaml
+  - .gitignore
+  - venv

roles/oneagent/examples/advanced_config/advanced_config.yml

@@ -3,8 +3,6 @@
     Download OneAgent installer in specific version to a custom directory with additional OneAgent install parameters.
     Both linux_other and linux_arm have different user specified by platform args parameter.
   hosts: linux_other,linux_arm
-  collections:
-    - dynatrace.oneagent
   # credentials.yml file contains oneagent_environment_url and
   # oneagent_paas_token variables that needs to be stored securely
   vars_files:
@@ -22,4 +20,4 @@
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent

roles/oneagent/examples/local_installer/local_installer.yml

@@ -3,9 +3,7 @@
     Basic OneAgent installation using a local installer. Hosts placed in unix hosts groups have its local installer paths defined in inventory file.
     Main node communicates with Windows hosts over SSH.
   hosts: windows,unix
-  collections:
-    - dynatrace.oneagent
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent

roles/oneagent/examples/oneagentctl_config/oneagentctl_config.yml

@@ -1,8 +1,6 @@
 ---
 - name: Apply host level configuration with oneagentctl
   hosts: linux_other
-  collections:
-    - dynatrace.oneagent
   vars:
     oneagent_install_args:
       - --set-host-name=new_host_name
@@ -12,4 +10,4 @@
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent

roles/oneagent/tests/resources/installers/Dynatrace-OneAgent-Linux.sh

@@ -1,20 +1,20 @@
-#!/bin/sh
+#!/bin/bash -eu
 
 # This script acts as a self contained installer of the procuct
 
-set -e
-
 readonly DEFAULT_INSTALL_DIR="/opt/dynatrace/oneagent"
 readonly INSTALLER_VERSION="##VERSION##"
 readonly DEPLOYMENT_CONF_PATH="/var/lib/dynatrace/oneagent/agent/config"
 
 readonly UNINSTALL_SCRIPT="uninstall.sh"
+# shellcheck disable=SC2155
 readonly UNINSTALL_CODE="$(cat <<-ENDUNINSTALL
 ##UNINSTALL_CODE##
 ENDUNINSTALL
 )"
 
 readonly ONEAGENTCTL_BIN="oneagentctl"
+# shellcheck disable=SC2155
 readonly ONEAGENTCTL_CODE="$(cat <<-ENDCTL
 ##ONEAGENTCTL_CODE##
 ENDCTL
@@ -61,6 +61,7 @@ deployUninstallScript() {
 }
 
 applyConfig() {
+	# shellcheck disable=SC2086
 	"${INSTALL_DIR}/agent/tools/${ONEAGENTCTL_BIN}" ${CTL_PARAMS}
 }
 

roles/oneagent/tests/resources/installers/oneagentctl.sh

@@ -1,9 +1,6 @@
-#!/bin/bash
+#!/bin/bash -eu
 
 # This file simulates deployment functionalities of oneagentctl binary, used to configure installation.
-
-set -e
-
 readonly INSTALLER_VERSION="##VERSION##"
 readonly DEPLOYMENT_CONF_PATH="/var/lib/dynatrace/oneagent/agent/config"
 
@@ -14,6 +11,7 @@ cutVariable() {
 	printf "%s" "${variable}" | cut -d "${delimiter}" -f "${fields}"
 }
 
+# shellcheck disable=SC2155
 saveToConfig() {
 	while [ $# -gt 0 ]; do
 		# example command: --set-host-property=TENANT=tenant1
@@ -36,6 +34,7 @@ saveToConfig() {
 }
 
 readFromConfig() {
+	# shellcheck disable=SC2155
 	local getterType="$(cutVariable "${1}" "-" "5-")"
 
 	if [ "${getterType}" = "properties" ]; then
@@ -49,7 +48,7 @@ main() {
 	if [ "${1}" = '--version' ]; then
 		printf '%s\n' "${INSTALLER_VERSION}"
 	elif printf "%s" "${1}" | grep -q "^--get"; then
-		readFromConfig ${1}
+		readFromConfig "${1}"
 	elif printf "%s" "${1}" | grep -q "^--set"; then
 		saveToConfig "$@"
 	fi