Fixes UTF-16 encoded .addin manifests fail upon loading (#70) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"RevitTestFramework fails to Run If an Addin manifest is encoded in UTF-16. When run from the console using RevitTestFrameworkConsole.exe, the error message is "There is no Unicode byte order mark. Cannot switch to Unicode." There is no error message shown in the GUI."
spitznagel
changed the title
spitznagel
changed the title
marchello2000
pushed a commit
to upcodes/RevitTestFramework
that referenced
this pull request
Jun 27, 2018
|
Thank you, @spitznagel : this has been incorporated into https://github.com/upcodes/RevitTestFramework |
ZiyunShang
pushed a commit
that referenced
this pull request
Mar 22, 2019
* Group tests by model with the `GroupByModel` param
* Tests in same fixture with same model path will run with the same model (without reopening the model)
* Additional fixes:
- Remember the directory for file pickers
- Automatically set the working/results directory
- Automatically infer the version of Revit to use from the assembly (based on the RevitAPI linked against)
- Clean up a bunch of stale variables, update parts to modern C# standards
- Fix by category grouping to show tests that aren't in a category
* Nuget package definition
* Fix the test runner such that it spits out an error when a text model is not found
* Various UI improvements:
* Show how many tests pass/fail after a test run
* Auto expand tree with failing tests
* fixup! Merge pull request #4 from marchello2000/mark/failing_tests_indicator
* Clarity improvements:
* Add `ERROR` and `WARNING` to appropriate WriteLines to clearly highlight when
something goes wrong
* Compact the UI a bit and give more room to console logger
* Clearly state how many tests pass/fail/skip in the last run in the console log for the gui
* Nuget version update
* Add ability to marshal console logs from unit test
* Spit out information to console as the test complete
* Add ability to clear in the console box
* Update nuspec version and readme
* Add missing empty.rfa file to the nuget package
* Porting fix for #71
* Properly fail tests whose model isn't found
* Fix null deref in console mode
* Add ability to specify wildcard for a model file name
The way it's implemented is as follows:
1. During assembly load, check if a test has a wildcard for the model, e.g.
```
[TestModel(@"C:\RevitModels\test_models\*.rvt")]
```
or
```
[TestModel(@"C:\RevitModels\test_models\*.rfa")]
```
2. Enumerate all files that match the wildcard in the specified directory
3. For each model file found, create a separate entry for the current test with this model
* Add proper error handling for wildcard models
Add error when no model files are found with a given wildcard
* Initialize output redirector earlier to catch command line arguments
* Add a timeout to Revit termination
In case Revit doesn't terminate within a timeframe (45s) it is force terminated
after test run is complete (only works for -continuous right now)
* Update README.md
* Automated build with AppVeyor
* Use Nugets for Revit dependencies (e.g. RevitAPI.dll and RevitAddingUtility.dll)
* Remove platform architecture warnings
* Remove some unused variables and other warnings from build
* Remove double definition of NUnitResultTypes
* Add ability to override Revit installation enumeration during UnitTests for CI machines with Revit
* Update Nuget package and add AppVeyor.yaml file
* Fix automatic nuget publishing
* Add instructions on how to run RTF in CI
* Pull request fixups
Revert to ReflectionOnlyLoadFrom for assembly loader because Dynamo relies on it
* PR Feedback:
* Ensure all new methods/classes have XML docs
* Ensure all memebers have access modifiers
* Update readme
* PR Feedback: do not distribute nunit/prism/etc libraries
Using Costura to merge the needed binaries into the RTF assemblies
such that they don't need to be redistributed without correct nuget usage
* Adding license info for used dlls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RevitTestFramework fails to Run If an Addin manifest is encoded in UTF-16. When run from the console using RevitTestFrameworkConsole.exe, the error message is "There is no Unicode byte order mark. Cannot switch to Unicode." There is no error message shown in the GUI, but it still fails.
We can solve this problem by using StreamReader to automatically detect the encoding of the .addin manifest. Once loaded, we can pass the StreamReader directly to XmlDocument. This works for both UTF-8 and UTF-16 manifests.