Fix CurtainPanel.ByElements node returning null as soon as curtain wall contains doors or windows #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n cases when some curtain panels are doors or windows
AdrianaStanica
commented
Mar 11, 2024
| } | ||
| else | ||
| { | ||
| result.Add(null); |
There was a problem hiding this comment.
this is the actual code change
Mikhinja
approved these changes
Mar 11, 2024
update local branch with latest master
This reverts commit 1638ef2.
Mikhinja
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a quick fix for this issue in which CurtainPanel.ByElements node returns null if the curtain wall has doors or windows. This change fixes only part of the problem, meaning that now the node will display the list of curtain panels, while curtain windows or curtain door elements will be displayed as null values in that list. Returning doors and windows as well will be treated as a separate issue.
This PR has a lot of changes because of reformatting the file according to current coding standards.
REVIT-219424
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@Mikhinja