-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-7839] Wires & Pins: improve snapping tolerance #15683
base: master
Are you sure you want to change the base?
[DYN-7839] Wires & Pins: improve snapping tolerance #15683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7839
UI Smoke TestsTest: success. 11 passed, 0 failed. |
? |
hi @ivaylo-matov Would love more time reviewing this PR, curious about the performance impact of the second connector here. Given this change would affect every connector, would you make some time comparison in bigger graphs? |
Purpose
PR aims to address DYN-7839.
This update enhances the snapping tolerance for connectors when interacting with the ConnectorAnchor.
A second, invisible connector has been introduced to handle MouseEnter and MouseLeave events. This invisible connector features a dynamic
StrokeThickness
that adjusts based on the current zoom level:Zoom > 1: The
StrokeThickness
matches the visible connector's thickness (default: 3).Zoom < 1: The
StrokeThickness
dynamically scales with the zoom factor, ensuring that the actual snapping area on the screen remains consistent regardless of the zoom level.The
StrokeThickness
is doubled at smaller zoom factors to improve the responsiveness.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Improved connector snapping at lower zoom levels for Pin and Watch buttons.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov