Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7790 fix package tour terms of use step #15681

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

chubakueno
Copy link
Contributor

@chubakueno chubakueno commented Nov 21, 2024

Purpose

Dynamo.Wpf.UI.GuidedTour.GuidesValidationMethods.ExecuteTermsOfServiceFlow searches for the TermsOfUse window as owned by DynamoView in GuideUtilities.FindWindowOwned(stepInfo.HostPopupInfo.WindowName, stepInfo.MainWindow as Window) but can't find it due to it being owned by no one (null). This PR thus allows the user to complete the packages tour. Allows for dependent Package Tour testing ticket DYN-7664 to be completed.

Process without previously accepted TOU:
2024-11-21 13-50-17
Process with previously accepted TOU:
2024-11-21 13-52-39

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Solve DYN-7790 to fix Packages interactive tour

Reviewers

@RobertGlobant20
@QilongTang

FYIs

@avidit

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7790

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a GIF of the packages tour when the TermsOfUse has not been accepted yet?

@chubakueno
Copy link
Contributor Author

LGTM, could you add a GIF of the packages tour when the TermsOfUse has not been accepted yet?

Added both flows (with and without previously accepted TOU)

@QilongTang QilongTang added this to the 3.5 milestone Nov 21, 2024
@QilongTang QilongTang merged commit 3e20369 into DynamoDS:master Nov 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants