DYN-7409: Properly use the userData CLI parameter #15558
Conversation
Fall back to default if no preferences file present.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7409
UI Smoke TestsTest: success. 11 passed, 0 failed. |
| PathManager.Instance.AssignHostPathAndIPathResolver(string.Empty, pathResolver); | ||
|
|
||
| if (!File.Exists(PathManager.Instance.PreferenceFilePath)) |
There was a problem hiding this comment.
will this traverse the newly set user data folder from the command line args and check for a prefs file there?
There was a problem hiding this comment.
Yes. If userData parameter is, e.g. %appData%\Dynamo\Dynamo Revit, PathManager.Instance.PreferenceFilePath is %appData%\Dynamo\Dynamo Revit\3.4\DynamoSettings.xml.
|
can you say a bit more about this: |
Added some detail in the description, let me know if it's still unclear. I'm struggling a bit to figure out how to test this. I can make a test which starts a separate CLI process with the |
|
@twastvedt I can't think of anything great as is, you could introduce something to the exec session like pref path and then create a graph to return that? |
|
Updated the PR description to use the PR template, feel free to merge |
Haven't had a chance to get to tests for this, I converted to draft for now, might be a bit. |
Purpose
Fixes the following bug:
The
userDataCLI argument seems to intend to set the user data directory, but the value passed is only used for loading packages, not for loading the preferences file. Preferences are still loaded from the default "Dynamo Core" folder.When running the CLI, the Preferences singleton first gets initialized here, using the PathResolver created the line above, which is constructed without the userData folder from the cli args. Only a few lines later, when calling StartDynamoWithDefaultConfig, is the userData cli arg used, but by then Preferences has already been initialized.
This PR modifies the initial PathResolver above to make use of the
userDataparameter. If the preferences file does not exist at theuserDatafolder it falls back to using the default user data folder for preferences (preserving current behavior).Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix a bug with setting preferences file location via
userdataparameter in CLI.Reviewers
@mjkkirschner
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of