DYN-7409 Execution session preference file path #15511
Conversation
twastvedt
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7409
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
@twastvedt Is this required in Dynamo 3.4? This never made in, just FYI |
|
Not required. I never got to it. Will try to get to it for 3.5. Do you have any thoughts about Mike's question, @QilongTang ? Makes sense to me, but I don't think I have the experience to say definitively. |
| /// <summary> | ||
| /// The path to the preference file that is being used by Dynamo. | ||
| /// </summary> | ||
| public static readonly string PreferenceFilePath = nameof(PreferenceFilePath); |
There was a problem hiding this comment.
Hi @twastvedt I think @mjkkirschner was asking here if we want to make the entire PathManager available and readonly instead of just the PreferenceFilePath.
There was a problem hiding this comment.
Yes, I'm aware of what he's asking. I'm not sure how to answer. Are you?
Purpose
Add the current preference file path to Execution Session to make it available to nodes.
We'd like this for the GraphEngine node in particular, to allow us to match the current preferences in the Dynamo instance that we spin up.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Added file path to the current preferences file (
PreferenceFilePath) toDynamo.Configuration.ExecutionSession.Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of