fix: Add customerId in user table #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EliasFernandes03
commented
Jan 12, 2024
•
EliasFernandes03
commented
- Creating a new field customerId to save the stripe customer's Id
- Implementing new service for update CustomerId
Marcus-D-Forte
requested changes
Jan 13, 2024
src/users/validationUserModel.ts
Outdated
There was a problem hiding this comment.
não faltou atualizar validationDbUsers.ts ?
There was a problem hiding this comment.
O validationDbUsers.ts é uma validação com os campos required, o bruno e eu estamos pensando na possibilidade de que o cadastro da stripe possa não acontecer, nesse caso o nosso cadastro não seria impactado. Quando o usuario se cadastrar na stripe de fato , ele atualiza a tabela do users com o campo customerId.
src/interfaces.ts
Outdated
| @@ -15,6 +15,7 @@ export interface IUsers { | |||
| complement: string | |||
| quota: UserQuota | |||
| validatedMail: boolean | |||
| customerId: string | |||
There was a problem hiding this comment.
esse campo tá ambíguo.. oq é customerID?
se for um campo referente a pagamento, usar algo como paymentServiceCustomerId
There was a problem hiding this comment.
Concordo com o Marcus. É bom deixar claro que é um id referente ao serviço de um terceiro
added 13 commits
January 15, 2024 14:50
brunonnalvesduna
approved these changes
Jan 16, 2024
Marcus-D-Forte
approved these changes
Jan 19, 2024
added 3 commits
January 23, 2024 10:30
…form-db into feat/StripeIntegration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.