Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part II fixes #510

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Part II fixes #510

wants to merge 14 commits into from

Conversation

Toranks
Copy link
Collaborator

@Toranks Toranks commented Jun 23, 2023

  • Hero loyal units receives TRAIT_LOYAL_HERO to avoid overlap of overlays.
  • Messages prestart to start (In prestart they overlap and it looks bad)
  • Antediluvian movement fix max_moves=0 not supported under [side], better use ai_special=guardian

Still in draft until I finish part II

@Dugy
Copy link
Owner

Dugy commented Jun 23, 2023

Some prestart messages were intended to be shown before the map is shown. Please take that into consideration.

@Toranks
Copy link
Collaborator Author

Toranks commented Jun 23, 2023

If I see that the map does narration spoilers, I can convert them to story messages with a flat black background.
Anyway, most of the ones I've seen so far go right after the story screen (which has its own narration), so it doesn't matter that the narrator speaks during the beginning of the scenario.

@Dugy
Copy link
Owner

Dugy commented Jun 24, 2023

All right.

@Toranks
Copy link
Collaborator Author

Toranks commented Jun 26, 2023

I have recreated the conversation with Councilor Charles to show him on the map instead of on prestart. This is the result:

2023-06-26.03-15-19.mp4

@Dugy
Copy link
Owner

Dugy commented Jun 26, 2023

That conversation between Charles and Lethalia was taking place in an imaginary palace conference room represented by a black background. Your change turns it into a ramparts chat. Though... if I got a picture of a palace conference room, it would not be able to use that as background in the prestart event. So I guess it's better your way.

@Toranks
Copy link
Collaborator Author

Toranks commented Jun 26, 2023

It can also be moved to [story] [part] with the background you say. I did it this way because the conversation in prestart was quite linear with the one in start, and it didn't lose meaning if it was shown on the map.

@Dugy
Copy link
Owner

Dugy commented Jun 27, 2023

Overlaying portraits in [story] is a bit of a problem, let's keep it the way you've done it.

@Toranks
Copy link
Collaborator Author

Toranks commented Jul 3, 2023

Conditionals also work under [story]
imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants