Add offset to offbeat retrigger effect #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behavior resulted in the retriggered sample to be that of the nearest division of `updatePeriod`. We now add samples to the start of that such that the retriggered sample will always be the sample on which the FX hold starts.
|
Just checking to see if there's any chance of merging this into develop/master. If you want more testing I would be happy to assist in that. Given how common retriggers are, this fix would bring many charts closer to the sound that the charter intended. |
|
Yeah with conflict fix and I'm gonna take it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior resulted in the retriggered sample to be that of the nearest division of
updatePeriod. We now add samples to the start of that such that the retriggered sample will always be the sample on which the FX hold starts.Old incorrect behavior: https://cdn.discordapp.com/attachments/384032012249464832/708104951318183975/fx_wrong.mp4
New correct behavior: https://cdn.discordapp.com/attachments/384032012249464832/708105005101744179/usc_fx_fixed.mp4
This time around the fix doesn't break other retriggers: https://cdn.discordapp.com/attachments/384032012249464832/708105235842727946/usc_fx_same.mp4