Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 manipulations for REMOVABLE SUBSYSTEMS. #92

Closed
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- manipulation DoesDescriptorRepresentARemovableSubsystem for devices
- manipulation DisconnectRemovableSubsystem for devices
- manipulation ConnectRemovableSubsystem for devices
- manipulation PhysicallyDisconnectRemovableSubsystemAfterSettingActivationStateOnOrStndBy
- manipulation RequestIndicationOfNextCalibrationTimeRequired for devices
- manipulation IndicateTimeOfNextCalibrationToUser for devices
Expand Down
17 changes: 17 additions & 0 deletions src/t2iapi/device/device_responses.proto
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,20 @@ message InsertContainmentTreeEntryForSequenceIdResponse{
string handle = 2; // descriptor handle which is representing the requested BICEPS CONTAINMENT TREE ENTRY
// in the device's current MDIB
}

/*
Response containing a boolean answer.
*/
message TrueFalseResponse {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure if we should use this manipulation at all, i would prefer using the manipulation

DisconnectRemovableSubsystem

directly and evaluating the RESULT_NOT_SUPPORTED response

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DoesDescriptorRepresentARemovableSubsystem() is a manipulation that queries information, while DisconnectRemovableSubsystem() changes the state of the device quite significantly. Independent of the TestCase I do see a usecase for both of them.

We also have GetRemovableDescriptorsOfClass() and RemoveDescriptor(). When following your argumentation, then the first would also be redundant.

BasicResponse status = 1; // status of the rpc
bool answer = 2; // Boolean answer
}

/*
Response containing the mdib version from which on the requested change will be effective.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
message MdibVersionResponse {
BasicResponse status = 1; // status of the rpc
string sequence_id = 2; // SequenceId of MdibVersion.
int64 mdib_version = 3; // Mdib Version from which on the change will be effective.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string sequence_id = 2; // SequenceId of MdibVersion.
int64 mdib_version = 3; // Mdib Version from which on the change will be effective.
string sequence_id = 2; // @SequenceId of @MdibVersion
int64 mdib_version = 3; // @MdibVersion from which on the change will be effective

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (similarly)

}
31 changes: 27 additions & 4 deletions src/t2iapi/device/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,22 @@ service DeviceService {
returns (t2iapi.device.GetRemovableDescriptorsResponse);

/*
Remove a descriptor from the device MDIB.
Remove a descriptor from the device MDIB using a DescriptionManipulationReport.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc RemoveDescriptor(BasicHandleRequest) returns (BasicResponse);

/*
Insert a descriptor into the device MDIB.
Insert a descriptor into the device MDIB using a DescriptionManipulationReport.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc InsertDescriptor(BasicHandleRequest) returns (BasicResponse);

/*
Insert an mds descriptor into the device MDIB.
Insert an mds descriptor into the device MDIB using a DescriptionManipulationReport.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc InsertMdsDescriptor (google.protobuf.Empty) returns (t2iapi.device.InsertMdsDescriptorResponse);

/*
Remove an mds descriptor from the device MDIB.
Remove an mds descriptor from the device MDIB using a DescriptionManipulationReport.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc RemoveMdsDescriptor (BasicHandleRequest) returns (BasicResponse);

Expand Down Expand Up @@ -222,4 +222,27 @@ service DeviceService {
*/
rpc InsertContainmentTreeEntryForSequenceId (InsertContainmentTreeEntryForSequenceIdRequest)
returns (InsertContainmentTreeEntryForSequenceIdResponse);

/*
Determine whether the given descriptor represents a REMOVABLE SUBSYSTEM in the sense of
IEEE Std 11073-10700-2022.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc DoesDescriptorRepresentARemovableSubsystem(BasicHandleRequest)
returns (TrueFalseResponse);

/*
Physically disconnect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays disconnected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use this text instead (we are using it also for other manipulations)

The manipulated state shall be persistent until a next manipulation call. If the device is not able to maintain
the static state, it shall return RESULT_NOT_SUPPORTED.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Physically disconnect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays disconnected
Physically disconnect the REMOVABLE SUBSYSTEM (as defined in
IEEE Std 11073-10700-2022) represented by the given descriptor. Ensure that it stays disconnected

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

at least until the next manipulation call.
Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is disconnected.
*/
rpc DisconnectRemovableSubsystem(BasicHandleRequest)
returns (MdibVersionResponse);

/*
Physically connect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays connected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Physically connect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays connected
Physically connect the REMOVABLE SUBSYSTEM (as defined in
IEEE Std 11073-10700-2022) represented by the given descriptor. Ensure that it stays connected

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

at least until the next manipulation call.
Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is connected.
*/
rpc ConnectRemovableSubsystem(BasicHandleRequest)
returns (MdibVersionResponse);
}
Loading