-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3 manipulations for REMOVABLE SUBSYSTEMS. #92
Changes from 8 commits
1f6143f
c89de63
8984966
658e6db
1e041fc
4ef015b
8bd6cf6
1996883
8c518ff
bbfeaf3
6ec5da4
50bc949
f19f26c
5c41714
7888bdc
111e756
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -73,3 +73,20 @@ message InsertContainmentTreeEntryForSequenceIdResponse{ | |||||||||
string handle = 2; // descriptor handle which is representing the requested BICEPS CONTAINMENT TREE ENTRY | ||||||||||
// in the device's current MDIB | ||||||||||
} | ||||||||||
|
||||||||||
/* | ||||||||||
Response containing a boolean answer. | ||||||||||
*/ | ||||||||||
message TrueFalseResponse { | ||||||||||
BasicResponse status = 1; // status of the rpc | ||||||||||
bool answer = 2; // Boolean answer | ||||||||||
} | ||||||||||
|
||||||||||
/* | ||||||||||
Response containing the mdib version from which on the requested change will be effective. | ||||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
*/ | ||||||||||
message MdibVersionResponse { | ||||||||||
BasicResponse status = 1; // status of the rpc | ||||||||||
string sequence_id = 2; // SequenceId of MdibVersion. | ||||||||||
int64 mdib_version = 3; // Mdib Version from which on the change will be effective. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done (similarly) |
||||||||||
} |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -81,22 +81,22 @@ service DeviceService { | |||||||
returns (t2iapi.device.GetRemovableDescriptorsResponse); | ||||||||
|
||||||||
/* | ||||||||
Remove a descriptor from the device MDIB. | ||||||||
Remove a descriptor from the device MDIB using a DescriptionManipulationReport. | ||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
*/ | ||||||||
rpc RemoveDescriptor(BasicHandleRequest) returns (BasicResponse); | ||||||||
|
||||||||
/* | ||||||||
Insert a descriptor into the device MDIB. | ||||||||
Insert a descriptor into the device MDIB using a DescriptionManipulationReport. | ||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
*/ | ||||||||
rpc InsertDescriptor(BasicHandleRequest) returns (BasicResponse); | ||||||||
|
||||||||
/* | ||||||||
Insert an mds descriptor into the device MDIB. | ||||||||
Insert an mds descriptor into the device MDIB using a DescriptionManipulationReport. | ||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
*/ | ||||||||
rpc InsertMdsDescriptor (google.protobuf.Empty) returns (t2iapi.device.InsertMdsDescriptorResponse); | ||||||||
|
||||||||
/* | ||||||||
Remove an mds descriptor from the device MDIB. | ||||||||
Remove an mds descriptor from the device MDIB using a DescriptionManipulationReport. | ||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
*/ | ||||||||
rpc RemoveMdsDescriptor (BasicHandleRequest) returns (BasicResponse); | ||||||||
|
||||||||
|
@@ -222,4 +222,27 @@ service DeviceService { | |||||||
*/ | ||||||||
rpc InsertContainmentTreeEntryForSequenceId (InsertContainmentTreeEntryForSequenceIdRequest) | ||||||||
returns (InsertContainmentTreeEntryForSequenceIdResponse); | ||||||||
|
||||||||
/* | ||||||||
Determine whether the given descriptor represents a REMOVABLE SUBSYSTEM in the sense of | ||||||||
IEEE Std 11073-10700-2022. | ||||||||
ben-Draeger marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
*/ | ||||||||
rpc DoesDescriptorRepresentARemovableSubsystem(BasicHandleRequest) | ||||||||
returns (TrueFalseResponse); | ||||||||
|
||||||||
/* | ||||||||
Physically disconnect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays disconnected | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please use this text instead (we are using it also for other manipulations)
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||||||||
at least until the next manipulation call. | ||||||||
Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is disconnected. | ||||||||
*/ | ||||||||
rpc DisconnectRemovableSubsystem(BasicHandleRequest) | ||||||||
returns (MdibVersionResponse); | ||||||||
|
||||||||
/* | ||||||||
Physically connect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays connected | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||||||||
at least until the next manipulation call. | ||||||||
Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is connected. | ||||||||
*/ | ||||||||
rpc ConnectRemovableSubsystem(BasicHandleRequest) | ||||||||
returns (MdibVersionResponse); | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure if we should use this manipulation at all, i would prefer using the manipulation
directly and evaluating the RESULT_NOT_SUPPORTED response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DoesDescriptorRepresentARemovableSubsystem() is a manipulation that queries information, while DisconnectRemovableSubsystem() changes the state of the device quite significantly. Independent of the TestCase I do see a usecase for both of them.
We also have GetRemovableDescriptorsOfClass() and RemoveDescriptor(). When following your argumentation, then the first would also be redundant.