-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3 manipulations for REMOVABLE SUBSYSTEMS. #92
Closed
ben-Draeger
wants to merge
16
commits into
Draegerwerk:main
from
ben-Draeger:manipulations-for-removable-subsystems
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1f6143f
added 3 manipulations for REMOVABLE SUBSYSTEMS.
ben-Draeger c89de63
fixed Linter warning.
ben-Draeger 8984966
Merge branch 'main' into manipulations-for-removable-subsystems
ben-Draeger 658e6db
mdibVersion should be a BigInteger. Improved Documentation.
ben-Draeger 1e041fc
Updated CHANGELOG.md
ben-Draeger 4ef015b
Merge branch 'main' into manipulations-for-removable-subsystems
ben-Draeger 8bd6cf6
added the sequenceId to the Response.
ben-Draeger 1996883
fixed linter warning.
ben-Draeger 8c518ff
Update src/t2iapi/device/device_responses.proto
ben-Draeger bbfeaf3
Update src/t2iapi/device/service.proto
ben-Draeger 6ec5da4
Update src/t2iapi/device/service.proto
ben-Draeger 50bc949
Changes proposed by Reviewers.
ben-Draeger f19f26c
Merge branch 'manipulations-for-removable-subsystems' of https://gith…
ben-Draeger 5c41714
Update src/t2iapi/device/service.proto
ben-Draeger 7888bdc
Update src/t2iapi/device/service.proto
ben-Draeger 111e756
Update src/t2iapi/device/service.proto
ben-Draeger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure if we should use this manipulation at all, i would prefer using the manipulation
directly and evaluating the RESULT_NOT_SUPPORTED response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DoesDescriptorRepresentARemovableSubsystem() is a manipulation that queries information, while DisconnectRemovableSubsystem() changes the state of the device quite significantly. Independent of the TestCase I do see a usecase for both of them.
We also have GetRemovableDescriptorsOfClass() and RemoveDescriptor(). When following your argumentation, then the first would also be redundant.