Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add InsertContainmentTreeEntryForSequenceId #91

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- manipulation SetSystemContextActivationStateAndContextAssociation for combined settings
- manipulation SetMdsUiLanguage for devices
- manipulation GetMdsUiSupportedLanguages for devices
- manipulation InsertContainmentTreeEntryForSequenceId for devices

## [4.1.0] - 2024-02-22

Expand Down
9 changes: 9 additions & 0 deletions src/t2iapi/device/device_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,12 @@ message ProvideInformationAboutNextCalibrationRequest {
CalibrationState calibration_state = 2; // ComponentCalibrationState value to set as the next calibration
// information
}

/*
Request to make available the CONTAINMENT TREE ENTRY(as defined in IEEE Std 11073-10207-2017) that was previously
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
represented by the descriptor with the provided handle in the device's MDIB with the provided @SequenceId.
*/
message InsertContainmentTreeEntryForSequenceIdRequest {
string handle = 1; // descriptor handle which represented the CONTAINMENT TREE ENTRY
string sequence_id = 2; // @SequenceId of the devices MDIB where the requested CONTAINMENT TREE ENTRY was seen
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
}
10 changes: 10 additions & 0 deletions src/t2iapi/device/device_responses.proto
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,13 @@ message GetComponentHwVersionResponse {
BasicResponse status = 1; // status of the rpc
string hardware_version = 2; // Hardware version of the requested device component
}

/*
Response containing the descriptor handle which is representing the requested
CONTAINMENT TREE ENTRY(as defined in IEEE Std 11073-10207-2017 in the device's current MDIB.
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
*/
message InsertContainmentTreeEntryForSequenceIdResponse{
BasicResponse status = 1; // status of the rpc
string handle = 2; // descriptor handle which is representing the requested CONTAINMENT TREE ENTRY in
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
// the device's current MDIB
}
37 changes: 37 additions & 0 deletions src/t2iapi/device/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -182,4 +182,41 @@ service DeviceService {
*/
rpc IndicateTimeOfNextCalibrationToUser (BasicHandleRequest)
returns (BasicResponse);

/*
Make available the CONTAINMENT TREE ENTRY(as defined in IEEE Std 11073-10207-2017) that was previously
represented by the provided handle in the MDIB with the provided @SequenceId. If the CONTAINMENT TREE ENTRY is
absent in the current MDIB, it shall be inserted and its (new) handle shall be returned. If the
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
CONTAINMENT TREE ENTRY is already present in the current MDIB, only its handle shall be returned, no further
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
action is required.

Hint: Devices which use static handles for descriptors do not have to lookup the previous handles since
they stay the same.
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved

Example 1: returning the same handle for the Metric
- device presented an MDIB with the Metric handle "metric_1" in @SequenceID "123"
- device changes @SequenceID to "789" and presents a new MDIB
- metric with the handle "metric_1" is still present in the current MDIB
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
- InsertContainmentTreeEntryForSequenceId with handle="metric_1" and sequence_id="123" is executed
- "metric_1" is returned since the descriptor with this handle it is still available in the current MDIB
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
- no further action from the device is required

Example 2: returning a new handle for the MDS:
- device presented an MDIB with MDS handle "mds0" in @SequenceID "123"
- device changes @SequenceID to "789" and presents a new MDIB
- MDS with the handle "mds0" is still present in the current MDIB but it's handle changed to "mds10"
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
- InsertContainmentTreeEntryForSequenceId with handle="mds0" and sequence_id="123" is executed
- "mds10" is returned since the descriptor handle for that MDS has changed
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
- no further action from the device is required

Example 3: inserting the Channel into the current MDIB and returning the (new) handle:
- device presented the Channel with handle "channel123" in @SequenceID "123"
- device changes @SequenceID to "789" and presents a new MDIB
- channel with handle "channel123" is no longer present in the current MDIB
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
- InsertContainmentTreeEntryForSequenceId with handle="channel123" and sequence_id="123" is executed
- channel is inserted into the device's current MDIB
- the (new) handle of the inserted channel is returned
ldeichmann marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc InsertContainmentTreeEntryForSequenceId (InsertContainmentTreeEntryForSequenceIdRequest)
returns (InsertContainmentTreeEntryForSequenceIdResponse);
}
Loading