Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manipulation to create ContextState with Association, specific Validator and excluded Identification #80

Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
037acde
Added manipulation CreateContextStateWithAssocAndSpecificValidatorAnd…
ben-Draeger May 30, 2024
e99bc57
updated Changelog.
ben-Draeger May 30, 2024
f63be31
Merge branch 'main' into add_manipulation_CreateContextStateWithAssoc…
ben-Draeger May 31, 2024
8fddb9d
Updated manipulation.
ben-Draeger Jun 7, 2024
87c763b
Updated manipulation.
ben-Draeger Jun 10, 2024
2458ad6
Updated CHANGELOG.md and fixed linter issues.
ben-Draeger Jun 10, 2024
179319b
Updated manipulation.
ben-Draeger Jun 11, 2024
f3c1d55
simplified manipulation.
ben-Draeger Jun 12, 2024
aa3c04c
Fixed linter warning.
ben-Draeger Jun 12, 2024
2239065
WIP.
ben-Draeger Jun 13, 2024
b5a2412
updated return value of manipulation.
ben-Draeger Jun 13, 2024
6225903
Merge branch 'main' into add_manipulation_CreateContextStateWithAssoc…
ben-Draeger Jun 20, 2024
bdad961
changes proposed by reviewers.
ben-Draeger Jun 20, 2024
065fd9f
Reordered entries in changelog.
ben-Draeger Jun 21, 2024
9e2d065
Merge branch 'main' into add_manipulation_CreateContextStateWithAssoc…
ben-Draeger Jun 21, 2024
247b837
improved documentation of manipulation.
ben-Draeger Jun 21, 2024
46e0ef7
the manipulation
ben-Draeger Jun 21, 2024
0e00dd4
changes requested by reviewers.
ben-Draeger Jun 21, 2024
45a5466
changes proposed by Reviewers.
ben-Draeger Jun 24, 2024
a51f841
changes proposed by Reviewers.
ben-Draeger Jun 24, 2024
55c4777
changes proposed by Reviewers.
ben-Draeger Jun 24, 2024
8467d22
changes discussed in meeting on 2024.06.28
ben-Draeger Jun 28, 2024
4ee70b2
corrected a spelling error.
ben-Draeger Jul 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

- manipulation SetSystemContextActivationStateAndContextAssociation for combined settings
- manipulation CreateContextStateWithAssocAndSpecificValidatorAndExcludedIdentification for contexts

## [4.1.0] - 2024-02-22

Expand Down
14 changes: 14 additions & 0 deletions src/t2iapi/context/context_requests.proto
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,20 @@ message CreateContextStateWithAssocAndSpecificValidatorRequest {
ValidatorType validator_type = 3; // type of pm:Validator
}

/*
Request to manipulate the context state with @handle = #state_handle# so that
- it has @contextAssociation = #context_association#
- it has #num_validators# pm:Validator elements
- its pm:Identification changes (after the manipulation it should at least
differ from the last 2 pm:Identifications of the manipulated context state)
*/
message AssociateValidateAndChangeIdentificationOfContextStateRequest {
string state_handle = 1;
ContextAssociation context_association = 2;
string num_validators = 3;
}


/*
Request to associate a specific patient type.
*/
Expand Down
20 changes: 20 additions & 0 deletions src/t2iapi/context/service.proto
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,26 @@ service ContextService {
t2iapi.context.CreateContextStateWithAssocAndSpecificValidatorRequest)
returns (t2iapi.context.CreateContextStateWithAssociationResponse);

/*
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
Manipulate a given context state (specified by state_handle), such that
- has the given context_association value,
- has the given number of pm:Validators (num_validators)
- its pm:Identification changes so that it differs from the last 2 pm:Identifications
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
of this particular context state.
Shall return the handle of the context state. This context state shall either be
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
newly created or it shall be adapted from a previously existing context state of the same descriptor, by
- disassociating it (in case it was associated)
- changing its Validators and Identifications
- setting its @contextAssociation to the given value.
Note that changing the pm:Validator or pm:Identification elements of a context state might
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
require disassociating it, changing them and re-associating it again.
The manipulated state shall be persistent until a next manipulation call. If the device is not able to maintain
the static state, it shall return RESULT_NOT_SUPPORTED.
*/
rpc AssociateValidateAndChangeIdentificationOfContextState(
t2iapi.context.AssociateValidateAndChangeIdentificationOfContextStateRequest)
returns (BasicResponse);

/*
Create or adapt neonatal patient with a given type of association and
including the mothers identification.
Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/context/types.proto
pstaeck marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ enum ValidatorType {
}

/*
Represents types of contexts available in IEEE Std 11073-10207-2017.
Represents types of contexts available in IEEE Std 11073-10207-2017.
*/
enum ContextType {
CONTEXT_TYPE_PATIENT = 0;
Expand All @@ -78,4 +78,4 @@ enum ContextType {
CONTEXT_TYPE_OPERATOR = 3;
CONTEXT_TYPE_MEANS = 4;
CONTEXT_TYPE_ENSEMBLE = 5;
}
}
Loading