Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ChangeOperationModeStatus manipulation #71

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- gRPC version to 1.58.0
- protoc version to 24.1

### Removed

- manipulation ChangeOperationModeStatus for metrics

## [3.0.0] - 2023-09-11

### Added
Expand Down
8 changes: 0 additions & 8 deletions src/t2iapi/metric/metric_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ message SetMetricValuesInRangeRequest {
string upper = 3; // upper limit for setting the new pm:MetricValue/@Value or @Samples
}

/*
Request to change the status of an operation mode.
*/
message ChangeOperationModeStatusRequest {
string handle = 1; // handle of the enum metric, which represents the operation mode
OperationModeStatus operation_mode_status = 2; // defines if the operation mode status shall be applied
}

/*
Request a change of the status of a metric.
*/
Expand Down
11 changes: 0 additions & 11 deletions src/t2iapi/metric/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,6 @@ service MetricService {
rpc SetMetricValuesInRange (t2iapi.metric.SetMetricValuesInRangeRequest)
returns (BasicResponse);

/*
Change the status of an operation mode.

An operation mode represents a specific behaviour of a device that can be enabled, paused or disabled,
typically by the user.
BICEPS does not provide a model element out of the box that can be used for such a mode, thus the operation mode
is represented by a pm:EnumStringMetricDescriptor, as described by MPKP draft.
*/
rpc ChangeOperationModeStatus (t2iapi.metric.ChangeOperationModeStatusRequest)
returns (BasicResponse);

/*
Set the provided measurement, calculation or setting status for the metric of the provided handle. This is not the
AbstractMetricState/@ActivationState, but the internal state of the device.
Expand Down
9 changes: 0 additions & 9 deletions src/t2iapi/metric/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@ enum GenerationMode{
GENERATION_MODE_DEMO = 2;
}

/*
Defines the possible operation mode states according to MPKP draft.
*/
enum OperationModeStatus {
OPERATION_MODE_STATUS_ON = 0; // operation mode is applied
OPERATION_MODE_STATUS_OFF = 1; // operation mode is not applied, but available
OPERATION_MODE_STATUS_PAUSED = 2; // operation mode is not applied, but available
}

/*
Defines the possible non-exclusive MODE OF OPERATION according to MPKP (11073-10701-2022).
These are represented as an enum metric where the instances of pm:AllowedValue have the pm:Type of:
Expand Down
Loading