Changes proposed by Reviewers.

Draegerwerk · Oct 7, 2024 · 50bc949 · 50bc949
1 parent 8c518ff
commit 50bc949
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/t2iapi/device/device_responses.proto b/src/t2iapi/device/device_responses.proto
@@ -87,6 +87,6 @@ Response containing the @MdibVersion from which on the requested change will be
  */
 message MdibVersionResponse {
     BasicResponse status = 1;    // status of the rpc
-    string sequence_id = 2;      // SequenceId of MdibVersion.
-    int64 mdib_version = 3;      // Mdib Version from which on the change will be effective.
+    string sequence_id = 2;      // @SequenceId of Mdib.
+    int64 mdib_version = 3;      // @MdibVersion from which on the change will be effective.
 }
diff --git a/src/t2iapi/device/service.proto b/src/t2iapi/device/service.proto
@@ -231,16 +231,20 @@ service DeviceService {
         returns (TrueFalseResponse);
 
     /*
-    Physically disconnect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays disconnected
-    at least until the next manipulation call.
+    Physically disconnect the REMOVABLE SUBSYSTEM (as defined in IEEE Std 11073-10700-2022)
+    represented by the given descriptor. The manipulated state shall be persistent until a
+    next manipulation call. If the device is not able to maintain the static state,
+    it shall return RESULT_NOT_SUPPORTED.
     Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is disconnected.
     */
     rpc DisconnectRemovableSubsystem(BasicHandleRequest)
         returns (MdibVersionResponse);
 
     /*
-    Physically connect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays connected
-    at least until the next manipulation call.
+    Physically connect the REMOVABLE SUBSYSTEM  (as defined in IEEE Std 11073-10700-2022)
+    represented by the given descriptor. The manipulated state shall be persistent until a
+    next manipulation call. If the device is not able to maintain the static state,
+    it shall return RESULT_NOT_SUPPORTED.
     Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is connected.
     */
     rpc ConnectRemovableSubsystem(BasicHandleRequest)