only subscribe if actions are available

.github/workflows/build.yml

@@ -18,10 +18,10 @@ jobs:
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.12"
 
@@ -43,7 +43,7 @@ jobs:
           echo TARGZ=$(echo dist/*.tar.gz) >> $GITHUB_OUTPUT
 
       - name: Archive package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: distributions
           path: dist
@@ -62,15 +62,15 @@ jobs:
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist
@@ -99,15 +99,15 @@ jobs:
           --log-file pytest_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.log
 
       - name: Archive test result
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: success() || failure()  # upload artifacts also if test stage failed
         with:
           name: unittest_reports
           path: pytest_reports/unittest_report_${{ matrix.os }}_py${{ matrix.python-version }}_${{ env.SUFFIX }}.html
           retention-days: 5
 
       - name: Archive test log
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: success() || failure()  # upload artifacts also if test stage failed
         with:
           name: pytest_logs

.github/workflows/publish.yml

@@ -20,7 +20,7 @@ jobs:
 
     steps:
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist/
@@ -46,16 +46,16 @@ jobs:
 
     steps:
       - name: Check out Git repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Download Build
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: distributions
           path: dist
 
       - name: Download Unittest report
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: unittest_reports
           path: pytest_reports/

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - accessing a multikey may lead to IndexError [#359](https://github.com/Draegerwerk/sdc11073/issues/359)
 - fixed a bug where `log_prefix` can only be a string [#393](https://github.com/Draegerwerk/sdc11073/issues/393)
+- only send subscribe request if there are actions to subscribe to [#402](https://github.com/Draegerwerk/sdc11073/issues/402)
 
 ## [1.3.2] - 2024-03-18
 

src/sdc11073/sdcclient/sdcclientimpl.py

@@ -408,13 +408,14 @@ def startAll(self, notSubscribedActions=None, subscriptionsCheckInterval=None, a
                 subscribe_actions = set(available_actions) - notSubscribedActionsSet
                 if not subscribe_periodic_reports:
                     subscribe_actions -= set(periodic_actions)
-                try:
-                    self._subscribe(dpwsHosted, subscribe_actions,
-                                    self._onAnyStateEventReport)
-                except Exception as ex:
-                    self.all_subscribed = False  # => do not log errors when mdib versions are missing in notifications
-                    self._logger.error('startAll: could not subscribe: error = {}, actions= {}',
-                                       traceback.format_exc(), subscribe_actions)
+                if subscribe_actions:
+                    try:
+                        self._subscribe(dpwsHosted, subscribe_actions,
+                                        self._onAnyStateEventReport)
+                    except Exception as ex:
+                        self.all_subscribed = False  # => do not log errors when mdib versions are missing in notifications
+                        self._logger.error('startAll: could not subscribe: error = {}, actions= {}',
+                                           traceback.format_exc(), subscribe_actions)
 
         # connect self.isConnected observable to allSubscriptionsOkay observable in subscriptionsmanager
         def setIsConnected(isOk):