Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the SequenceId Ordering Problem #221

Merged

Conversation

ben-Draeger
Copy link
Collaborator

@ben-Draeger ben-Draeger commented Nov 14, 2024

SequenceIds are currently ordered lexicographically, which is wrong as the SDC standards define no order on them. We hence order them by the timestamp of the first message that they were used in.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer (midtuna)
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer (midtuna)
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer (midtuna)
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer (midtuna)
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer (midtuna)
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer (midtuna)

@ben-Draeger ben-Draeger removed the request for review from maximilianpilz November 27, 2024 09:03
@midttuna midttuna self-requested a review November 29, 2024 08:35
@ben-Draeger ben-Draeger merged commit 729356b into Draegerwerk:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants