-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove consumer test related implementations #150
Merged
pstaeck
merged 10 commits into
Draegerwerk:main
from
pstaeck:remove-consumer-test-related-implementations
Apr 19, 2024
Merged
Remove consumer test related implementations #150
pstaeck
merged 10 commits into
Draegerwerk:main
from
pstaeck:remove-consumer-test-related-implementations
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldeichmann
requested changes
Apr 3, 2024
sdccc/src/test/java/it/com/draeger/medical/sdccc/test_util/testprovider/TestProviderConfig.java
Outdated
Show resolved
Hide resolved
@pstaeck the current repository config requires signed commits for merging onto main, you have unsigned commits in this PR |
pstaeck
force-pushed
the
remove-consumer-test-related-implementations
branch
2 times, most recently
from
April 11, 2024 05:47
279dba4
to
fe6eff8
Compare
pstaeck
force-pushed
the
remove-consumer-test-related-implementations
branch
from
April 15, 2024 07:59
edff30c
to
36ac4d3
Compare
ldeichmann
requested changes
Apr 16, 2024
pstaeck
force-pushed
the
remove-consumer-test-related-implementations
branch
from
April 16, 2024 12:43
36ac4d3
to
513334f
Compare
ldeichmann
reviewed
Apr 17, 2024
…purpose of integration testing
…tions have been removed
pstaeck
force-pushed
the
remove-consumer-test-related-implementations
branch
from
April 17, 2024 13:20
0578a46
to
c27946a
Compare
…onsumer-test-related-implementations
ldeichmann
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCcc is not going to be used for consumer tests. Therefore, the purpose of the PR is to remove consumer test related implementations resp. move implementation of the test provider to test utils in order to use it for integration tests.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: