Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove consumer test related implementations #150

Merged

Conversation

pstaeck
Copy link
Contributor

@pstaeck pstaeck commented Mar 14, 2024

SDCcc is not going to be used for consumer tests. Therefore, the purpose of the PR is to remove consumer test related implementations resp. move implementation of the test provider to test utils in order to use it for integration tests.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

@pstaeck pstaeck requested a review from ldeichmann March 14, 2024 12:23
@pstaeck pstaeck self-assigned this Mar 14, 2024
@maximilianpilz
Copy link
Collaborator

@pstaeck the current repository config requires signed commits for merging onto main, you have unsigned commits in this PR

@pstaeck pstaeck force-pushed the remove-consumer-test-related-implementations branch 2 times, most recently from 279dba4 to fe6eff8 Compare April 11, 2024 05:47
@pstaeck pstaeck requested a review from ldeichmann April 11, 2024 07:26
@pstaeck pstaeck force-pushed the remove-consumer-test-related-implementations branch from edff30c to 36ac4d3 Compare April 15, 2024 07:59
@pstaeck pstaeck force-pushed the remove-consumer-test-related-implementations branch from 36ac4d3 to 513334f Compare April 16, 2024 12:43
@pstaeck pstaeck requested a review from ldeichmann April 16, 2024 13:13
@pstaeck pstaeck force-pushed the remove-consumer-test-related-implementations branch from 0578a46 to c27946a Compare April 17, 2024 13:20
@pstaeck pstaeck requested a review from ldeichmann April 17, 2024 13:44
@pstaeck pstaeck merged commit 69f5c8d into Draegerwerk:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants