Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt logs accordingly #147

Conversation

pstaeck
Copy link
Contributor

@pstaeck pstaeck commented Mar 7, 2024

The purpose of the pull request is to correct inconsistent messaging in SDCcc logs, in particular "No problems were found" together with "Test run was invalid" one after another.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

@pstaeck pstaeck requested a review from ben-Draeger March 7, 2024 12:04
@pstaeck pstaeck self-assigned this Mar 7, 2024
@pstaeck pstaeck changed the title SDCCC-1233 adapt logs accordingly adapt logs accordingly Mar 7, 2024
@pstaeck pstaeck closed this Mar 7, 2024
@pstaeck pstaeck deleted the SDCCC-1233-correct-inconsistent-messaging-in-sdccc-logs branch March 7, 2024 13:45
@pstaeck pstaeck restored the SDCCC-1233-correct-inconsistent-messaging-in-sdccc-logs branch March 7, 2024 13:49
@pstaeck pstaeck reopened this Mar 7, 2024
@pstaeck pstaeck closed this Mar 7, 2024
@pstaeck pstaeck deleted the SDCCC-1233-correct-inconsistent-messaging-in-sdccc-logs branch March 7, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant