Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSuite extension mechanism #146

Conversation

maximilianpilz
Copy link
Collaborator

@maximilianpilz maximilianpilz commented Mar 5, 2024

Make it easier to extend TestSuite with test cases and let TomlConfigParser read in inherited fields as well.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

@maximilianpilz maximilianpilz self-assigned this Mar 5, 2024
@belagertem
Copy link
Collaborator

Perhaps a changelog entry and/or a short explanation in the readme for the extension mechanism would be useful.

@maximilianpilz
Copy link
Collaborator Author

Perhaps a changelog entry and/or a short explanation in the readme for the extension mechanism would be useful.

I had thought about that and I even started writing one, but when reading through those files, I realised that they are more descriptions for the users of the resulting executable than they are descriptions for the developers. Thus I think this kind of change should not be written down there for consistency.

@belagertem
Copy link
Collaborator

Perhaps a changelog entry and/or a short explanation in the readme for the extension mechanism would be useful.

I had thought about that and I even started writing one, but when reading through those files, I realised that they are more descriptions for the users of the resulting executable than they are descriptions for the developers. Thus I think this kind of change should not be written down there for consistency.

You're probably right, it's fine for me.

@maximilianpilz maximilianpilz removed the request for review from pstaeck March 7, 2024 08:41
@maximilianpilz maximilianpilz merged commit 4be601f into Draegerwerk:main Mar 7, 2024
2 checks passed
pstaeck pushed a commit to pstaeck/SDCcc that referenced this pull request Mar 7, 2024
Make it easier to extend TestSuite with test cases and let
TomlConfigParser read in inherited fields as well.

# Checklist

The following aspects have been respected by the author of this pull
request, confirmed by both pull request assignee **and** reviewer:

* Adherence to coding conventions
  * [x] @maximilianpilz 
  * [x] @belagertem 
* Adherence to javadoc conventions
  * [x] @maximilianpilz 
  * [x] @belagertem 
* Changelog update (necessity checked and entry added or not added
respectively)
  * [x] @maximilianpilz 
  * [x] @belagertem 
* README update (necessity checked and entry added or not added
respectively)
  * [x] @maximilianpilz 
  * [x] @belagertem 
* config update (necessity checked and entry added or not added
respectively)
  * [x] @maximilianpilz 
  * [x] @belagertem 
* SDCcc executable ran against a test device (if necessary)
  * [x] @maximilianpilz 
  * [x] @belagertem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants