Fixed ReportWriter issue #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat are supported.
belagertem
requested changes
Feb 14, 2024
sdccc/src/main/java/com/draeger/medical/sdccc/tests/util/MdibHistorian.java
Outdated
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/tests/util/MdibHistorian.java
Show resolved
Hide resolved
…m/ben-Draeger/SDCcc into SDCCC-1235-fix-ReportWriter-usage
belagertem
requested changes
Feb 19, 2024
sdccc/src/main/java/com/draeger/medical/sdccc/tests/util/MdibHistorian.java
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/tests/util/MdibHistorian.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorian2Test.java
Outdated
Show resolved
Hide resolved
|
Please fix spotless findings |
|
Spotless warnings are fixed, Build is green again. |
belagertem
requested changes
Feb 21, 2024
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
belagertem
requested changes
Feb 21, 2024
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
|
Added assertDoesNotThrow()s to clarify the then-Part. |
belagertem
reviewed
Feb 22, 2024
sdccc/src/test/java/com/draeger/medical/sdccc/tests/util/MdibHistorianTest.java
Outdated
Show resolved
Hide resolved
belagertem
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReportProcessor.processReport() is now only called with ReportTypes that are supported.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: