Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Defect in Test Case for Glue:R0036_0. #136

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Fixed Defect in Test Case for Glue:R0036_0. #136

merged 10 commits into from
Feb 19, 2024

Conversation

ben-Draeger
Copy link
Collaborator

@ben-Draeger ben-Draeger commented Feb 9, 2024 •
edited by maximilianpilz
Loading

Fixed Defect in Test Case for Glue:R0036_0.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

maximilianpilz
maximilianpilz requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make use of the new license check from the main branch and update the copyright notices in the files that you changed

@ben-Draeger
Copy link
Collaborator Author

Done merging in the new licence check and updating the License Headers.

maximilianpilz
maximilianpilz requested changes Feb 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@maximilianpilz maximilianpilz merged commit bbdc6c3 into Draegerwerk:main Feb 19, 2024
2 checks passed
@ben-Draeger ben-Draeger deleted the SDCCC-1243-GlueR0036_0-fails-on-subscription-SOAPFault branch November 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianpilz maximilianpilz maximilianpilz approved these changes

Assignees

@ben-Draeger ben-Draeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-Draeger @maximilianpilz