Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NPE in Precondition #135

Merged

Conversation

ben-Draeger
Copy link
Collaborator

@ben-Draeger ben-Draeger commented Feb 7, 2024

The DescriptionModificationUptPrecondition (amongst others) threw a NullPointerException when encountering a DescriptionModificationReport containing a ReportPart without a ModificationType attribute.

This should fix the problem.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

@ben-Draeger ben-Draeger added the bug Something isn't working label Feb 7, 2024
@ben-Draeger ben-Draeger self-assigned this Feb 7, 2024
Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the build, it failed, and change the date of the copyright notice in the license headers of the files which you changed

@ben-Draeger
Copy link
Collaborator Author

The licence header check fails because I updated the license header in the 2 files I touched.
This can be rectified by merging in the change from PR #134, which introduced a more powerful github action for licence header checking that can deal with this type of headers.

Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make use of the new license check from the main branch

@ben-Draeger
Copy link
Collaborator Author

The Licence check was merged in from the main branch and it seems to work fine.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Maximilian Pilz <[email protected]>
@ben-Draeger ben-Draeger merged commit c0057f4 into Draegerwerk:main Feb 15, 2024
2 checks passed
@ben-Draeger ben-Draeger deleted the SDCCC-1236-NPE-in-Precondition branch February 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants