Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/rts core issues #42

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Bugfix/rts core issues #42

merged 3 commits into from
Oct 19, 2023

Conversation

aravind-raveendran
Copy link
Contributor

@aravind-raveendran aravind-raveendran commented Oct 19, 2023 •
edited
Loading

Description:

Fix the below issues:

  1. Making audio tracks mandatory before source playback
  2. Compare sourceid object instead of value comparison as main sources now arrive as empty string instead of nil
  3. Audio selection function has to use unsorted sources at all times as connection order is vital for picking the right audio track

@aravind-raveendran aravind-raveendran self-assigned this Oct 19, 2023
@aravind-raveendran aravind-raveendran merged commit 28b7924 into main Oct 19, 2023
2 checks passed
@aravind-raveendran aravind-raveendran deleted the bugfix/rts-core-issues branch October 19, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RameshDPrasad RameshDPrasad RameshDPrasad approved these changes

Assignees

@aravind-raveendran aravind-raveendran

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aravind-raveendran @RameshDPrasad