Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Lists endpoints #606

Merged
merged 21 commits into from
Mar 18, 2022
Merged

Support new Lists endpoints #606

merged 21 commits into from
Mar 18, 2022

Conversation

@igorbrigadir
Copy link
Contributor Author

There's a bit of extra refactoring with _write_with_progress function with this too.

@igorbrigadir igorbrigadir marked this pull request as ready for review March 15, 2022 04:27
@igorbrigadir
Copy link
Contributor Author

Ok, i think i managed to make all the commands work - there are still some inconsistencies with other commands, but i think this PR is large enough as it is, we can address the major inconsistencies in #608

@igorbrigadir igorbrigadir requested review from SamHames and edsu March 15, 2022 04:28
@SamHames
Copy link
Contributor

Ooh, exciting - I should have time to look at it this time tomorrow.

Copy link
Contributor

@SamHames SamHames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - found some interesting things poking around a few lists and didn't run into any issues with the functionality.

I pushed a few docstring tweaks for things that confused me until I looked at the output data.

@igorbrigadir
Copy link
Contributor Author

Oh thanks for catching those docstrings!

@igorbrigadir igorbrigadir merged commit 334cd68 into main Mar 18, 2022
@igorbrigadir igorbrigadir deleted the lists branch March 18, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new Lists endpoints
2 participants