Fixes for CR

DivanteLtd · Feb 26, 2020 · 9d80541 · 9d80541
1 parent d9c7a97
commit 9d80541
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/ScheduledExportBundle/Controller/GridConfigController.php b/src/ScheduledExportBundle/Controller/GridConfigController.php
@@ -3,6 +3,7 @@
 namespace Divante\ScheduledExportBundle\Controller;
 
 use Pimcore\Bundle\AdminBundle\Controller\AdminController;
+use Pimcore\Bundle\AdminBundle\HttpFoundation\JsonResponse;
 use Pimcore\Bundle\AdminBundle\Security\User\User;
 use Pimcore\Model\DataObject\ClassDefinition;
 use Pimcore\Model\GridConfig;
@@ -16,18 +17,21 @@
  */
 class GridConfigController extends AdminController
 {
+    /** @var string True indicator for share globally */
+    const SHARE_GLOBALLY_TRUE = "1";
+
     /**
      * @param Request $request
      * @return \Pimcore\Bundle\AdminBundle\HttpFoundation\JsonResponse
      * @throws \Exception
      *
      * @Route("/admin/scheduled-export/grid-config/get-list")
      */
-    public function getListAction(Request $request)
+    public function getListAction(Request $request) : JsonResponse
     {
         $user = $this->getAdminUser();
         $gridConfigs = new GridConfig\Listing();
-        $gridConfigs->setCondition("ownerId = ? or shareGlobally = 1", [$user->getId()]);
+        $gridConfigs->setCondition("ownerId = ? or shareGlobally = ?", [$user->getId(), self::SHARE_GLOBALLY_TRUE]);
         $gridConfigs->load();
         $result = [];