Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac binding for beg/end of line #1296

Merged

Conversation

windymilla
Copy link
Collaborator

Also fix bug in "Select to end of file" shortcut - it did sel to beg.

Also fix bug in "Select to end of file" shortcut - it did sel to beg.
@windymilla windymilla requested a review from srjfoo May 27, 2024 20:21
Copy link
Member

@srjfoo srjfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cmd+ left and right arrows now properly navigate to the beginning and end of a line, respectively. Yay!

Caveat on the "select from current position to end of file". There is a max buffer size for Macs (the problem is in XQuartz -- I haven't figured out what size it is, or whether it can be changed, and the ability to copy from GG and paste into a different instance of GG, or into a different application is fraught, anyway). "Select from current position to end of file" works now, but trying to copy and paste large amounts of text may have unexpected results. Make sure you save a copy of your file before trying it. I have had the GG window crash trying to copy as few as 300 lines.

@windymilla windymilla merged commit ea5be11 into DistributedProofreaders:master May 28, 2024
1 check passed
@windymilla windymilla deleted the Mac-line-start-end branch June 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants