Stop misconversion of fractions like 1/100,000 #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GG is supposed to convert fractions that don't contain commas, to use super/subscript or Unicode characters. E.g. 1/2000 will be converted, but 1/2,000 or 1/100,000 should not be. Previous negative lookahead caught 1/2,000 case, but converted the 1/10 in 1/100,000, since there was another digit before the comma. Fixed by adding optional digits to the negative lookahead.
|
Testing notes: Fractions that consist solely of digits and a slash (solidus or Unicode fraction slash) should be converted when using Tools, Convert Fractions. However, fractions that contain a comma shouldn't be, e.g. 1/2,000 or 1/100,000 |
cpeel
approved these changes
Oct 18, 2023
srjfoo
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GG is supposed to convert fractions that don't contain commas, to use super/subscript or Unicode characters.
E.g. 1/2000 will be converted, but 1/2,000 or 1/100,000 should not be. Previous negative lookahead caught 1/2,000 case, but converted the 1/10 in 1/100,000, since there was another digit before the comma.
Fixed by adding optional digits to the negative lookahead.
Fixes #1265