Playing around with highlight colors. #650
Conversation
|
And obviously, I did this wrong, because I forgot to set it to draft -- and also don't have everything in place to properly get things tested, so -- advice, please! Found the error and got it fixed -- but still wondering about setting it to a draft. It doesn't look like I can change it. |
The main one I really want to see changed is the spotlight color, from orange to darkorange, at least for the dark themes -- plain orange just doesn't show the white as well. The rest is playing around only for the colors for the dark themes to try to get better contrast between text color and background color.
srjfoo
force-pushed
the
hl-color-tweaks
branch
from
a434e55 to
c9cd079
Compare
|
If you want to set it to Draft, there should be a link just under the Reviewers list on the right. If you don't have that, then maybe I need to alter your access: |
Sometimes, I guess a user might want to be alerted to the fact that some quotes were straight instead of curly (though curly checking tool reports this)< and sometimes they might want to be alerted to which are single and which are double. Personally, I think it's better to have double quotes related, and single quotes related, which is what we currently have I think. The changes all look fine to me, if you're happy with the colors you've chosen. |
I'm happy with the colors I've chosen -- at least for now 😁 I do see the "change to draft" link now -- I didn't notice it last night, but I may not have been looking in the right place. I can't assign reviewers, and I don't know if that makes the difference, or if I was just blind! |
The main one I really want to see changed is the spotlight color, from
orangetodarkorange, at least for the dark themes -- white text just doesn't show as well onorangeas it does on thedarkorange.The rest is playing around only for the colors for the dark themes to try to get better contrast between text color and background color. Some of what I did was to change the double-quotes to use related but different colors, and the straight quotes, ditto, and make them (for dark theme -- I didn't touch the light theme) a bit more noticeable.
It occurrred to me later that it might be better to have straight quotes' colors be related, and curlies' colors be related, but that can be a talking point.
My feelings will absolutely not be hurt if y'all throw up your hands in horror. 😁 (on everything but the spotlight color change :D ) I'm starting this out as a draft. No big hurry.