Separate out File operations #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
windymilla
commented
Dec 3, 2023
windymilla
commented
- Separate out File operations into their own module
- Also fix key binding bug - by default Ctrl-O adds a blank line to a Text widget. We have bound it to Open File in our Text widget, but the class binding was still being called, so doing Open File also added a blank line (at the end of the file) so the file appeared "edited" immediately after loading. By returning the string "break" from the instance callback, it stops the class callback being called.
1. Separate out File operations into their own module 2. Also fix key binding bug - by default Ctrl-O adds a blank line to a Text widget. We have bound it to Open File in our Text widget, but the class binding was still being called, so doing Open File also added a blank line (at the end of the file) so the file appeared "edited" immediately after loading. By returning the string "break" from the instance callback, it stops the class callback being called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.