Type release queues #1402
Merged
Type release queues #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforced a few types in pinc/release_queue.inc that were annotated as it seemed like a low risk change and better for us. TEST=Tried the queue API and the stats endpoint.
cpeel
reviewed
Dec 19, 2024
Following cpeel's review comment.
chrismiceli
approved these changes
Dec 19, 2024
cpeel
approved these changes
Dec 21, 2024
srjfoo
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforced a few types in pinc/release_queue.inc
that were annotated as it seemed like a low
risk change and better for us.
TEST=Tried the queue API and the stats endpoint.
Sandbox: https://www.pgdp.org/~jchaffraix/c.branch/julien_type_release_queue/