Type Activity/Stage/Round/Pool #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those 4 are closely coupled so it made sense to handle them as a single PR. Unfortunately due to the coupling, the return of some key getters were not added, instead I added a comment explaning the situation. Properly typing will likely require some refactoring to split up the per-type lists, which is better done in a follow-up. TEST=Checked a user's available rounds, updated a project's state to confirm that the rounds/pools were still listed.
cpeel
reviewed
Oct 5, 2024
Co-authored-by: Casey Peel <[email protected]>
We round the user's registration to the closest .1 day so we must return a float from get_user_score.
cpeel
approved these changes
Oct 11, 2024
70ray
approved these changes
Oct 12, 2024
srjfoo
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those 4 are closely coupled so it made
sense to handle them as a single PR.
Unfortunately due to the coupling, the return of
some key getters were not added, instead I added
a comment explaning the situation. Properly typing will likely require some refactoring to split up
the per-type lists, which is better done in a follow-up.
TEST=Checked a user's available rounds, updated a project's state to confirm that the rounds/pools were still listed.
Update from cpeel: sandbox at https://www.pgdp.org/~cpeel/c.branch/julien_type_Activity/