use unique identifier for character pickers #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismiceli
reviewed
Oct 1, 2024
chrismiceli
approved these changes
Oct 1, 2024
| @@ -33,10 +34,11 @@ class CharacterSelector | |||
| } | |||
|
|
|||
| foreach ($picker_set->get_subsets() as $code => $picker) { | |||
There was a problem hiding this comment.
maybe a regular for loop would be more appropriate now that we are managing a counter variable.
There was a problem hiding this comment.
I think a foreach is still the right loop type because its iterating over a dictionary -- not an integer-indexed array. If PHP had enumerate() like python I'd say use that but it doesn't.
cpeel
approved these changes
Oct 1, 2024
srjfoo
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1334.
The problem was that an identifier is used to link the selector button with the appropriate picker set. This was based on the contents of the selector button which was the same for the two greek sets. Any unique identifier would serve. There are some issues with uniquid() but it appears that it sleeps for a microsecond at each invocation so it works for our purpose. A serial number would also work.
Sandbox at: https://www.pgdp.org/~rp31/c.branch/uniq_picker