Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise page_resume function #1170

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

70ray
Copy link
Collaborator

@70ray 70ray commented Apr 1, 2024

rename function because the page has not necessarily been saved.
Use page_require instead of a database access.

Sandbox at: https://www.pgdp.org/~rp31/c.branch/revise_resume

Copy link
Collaborator

@bpfoley bpfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice de-duplication of functionality.

@cpeel cpeel merged commit f2b970a into DistributedProofreaders:master Apr 4, 2024
10 checks passed
@70ray 70ray deleted the revise_resume branch April 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants