Add smoketests for all the tools/proofers/*.php pages. #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpeel
reviewed
Mar 27, 2024
| @@ -575,7 +609,7 @@ def main() -> int: | |||
| if args.verbose: | |||
| print(data.decode()) | |||
| if status not in expect_status or test_failed(logs): | |||
| print(f'Status: {status}') | |||
| print(f'Status: {status} (expected {epected_status})') | |||
There was a problem hiding this comment.
Suggested change
| print(f'Status: {status} (expected {epected_status})') | |
| print(f'Status: {status} (expected {expect_status})') |
There was a problem hiding this comment.
Time to get that linter :)
.github/workflows/ci.yml
Outdated
| @@ -120,6 +120,12 @@ jobs: | |||
| - name: Add smoketest DB entries | |||
| run: | | |||
| mysql -uroot -proot < SETUP/smoketests/test_tables.sql | |||
| - name: Create smoketest project dirs | |||
| run: | | |||
| mkdir -p $HOME/projects/projectID5e23a810ef693 | |||
There was a problem hiding this comment.
Should we put this inside a "smoketest_prep.sh" script and call it here rather than put the logic in the CI itself?
bpfoley
force-pushed
the
more-smoke
branch
2 times, most recently
from
8065d70 to
f5d464f
Compare
Add a placeholder project directory to allow some tests to work and re-enable some other pages that also require a project dir.
cpeel
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a placeholder project directory to allow some tests to work and re-enable some other pages that also require a project dir.