fix: magnet & freezing upgrade particles now respect player handedness #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafted as I forgot servers existed... |
|
Made it work on servers, and also made it respect whether the gadget is in the off hand/main hand. |
Anoyomouse
reviewed
Nov 23, 2023
| @@ -132,6 +133,8 @@ public void tick() { | |||
| Vec3 playerPos = player.position().add(0, player.getEyeHeight(), 0); | |||
| Vec3 blockPos = new Vec3(sourceX, sourceY, sourceZ); | |||
| Vec3 look = player.getLookAngle(); // or getLook(partialTicks) | |||
|
|
|||
|
|
|||
| //The next 3 variables are directions on the screen relative to the players look direction. So right = to the right of the player, regardless of facing direction. | |||
There was a problem hiding this comment.
Nitpick: Can this only have 1 enter, not 2?
There was a problem hiding this comment.
Whoops, missed that from moving some lines around, thanks for the find
Anoyomouse
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229 #179
Makes magnet & freezing upgrade particles respect player's selected main hand, and whether or not the gadget is in their off hand/main hand.
Demonstration:
2023-11-20.15-39-07.1.mp4