New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add feature to disable downloads #3465

Open

CathalMullan wants to merge 1 commit into DioxusLabs:main from CathalMullan:cli-disable-downloads

CathalMullan commented Dec 28, 2024 •

edited

Loading

Resolves #3457, #3417

Added 'no-downloads' feature to CLI.
Switched to using rustc instead of rustup to determine what targets are installed.
Lookup wasm-bindgen-cli from path when 'no-downloads' is enabled.
Don't try and install targets using rustup when 'no-downloads' is enabled.
Enable 'no-downloads' feature for Nix CI job.

Would have liked to have added tests, but mocking PATH is a little tricky to do safely across multiple tests.

Mainly need this for NixOS, but I suppose other environments may not want auto-downloading of tools either.

Also worth mentioning that the NixOS wiki now has a Dioxus page: https://wiki.nixos.org/wiki/Dioxus


          feat(cli): add feature to disable downloads

10ae561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet