Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windows Manganis Asset Hot Reload #3330

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

DogeDark
Copy link
Member

Manganis' asset manifest uses canonicalized assets and Windows may use the long-form path instead of regular C:\

@DogeDark DogeDark added bug Something isn't working hot-reload Related to the hot reload crate windows labels Dec 10, 2024
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Dec 10, 2024

Works for me on macos - I wish there was a way we could force canonicilization

packages/cli/src/serve/handle.rs Outdated Show resolved Hide resolved
@jkelleyrtp jkelleyrtp merged commit b20c8ac into DioxusLabs:main Dec 11, 2024
17 checks passed
@DogeDark DogeDark deleted the fix-hotreload branch December 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hot-reload Related to the hot reload crate windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants