Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sledgehammer bindings on web #2008

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix sledgehammer bindings on web #2008

merged 1 commit into from
Mar 6, 2024

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Mar 6, 2024

We were missing a let for els in the JS bindings.

It's weird that this wasn't getting caught by the fullstack tests. Not sure what happened - maybe we bypassed merge or something?

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we test that part of diffing in the headless tests currently. We should test more cases or try to do headless fuzzing

@jkelleyrtp jkelleyrtp merged commit 912885b into main Mar 6, 2024
9 checks passed
@jkelleyrtp jkelleyrtp deleted the jk/fix-web-hammer branch March 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants