Skip to content

Commit

Permalink
Don't panic if the duration is negative in try_get_or_insert (#3413)
Browse files Browse the repository at this point in the history
  • Loading branch information
ealmloff authored Dec 20, 2024
1 parent ecf8d16 commit 21fdecd
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions packages/isrg/src/memory_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ impl InMemoryCache {
let age = elapsed.num_seconds();
// The cache entry is out of date, so we need to remove it.
if let Some(invalidate_after) = self.invalidate_after {
if elapsed.to_std().unwrap() > invalidate_after {
tracing::trace!("memory cache out of date");
memory_cache.pop(route);
return Ok(None);
// If we can't convert to a std duration, the duration is negative and hasn't elapsed yet.
if let Ok(std_elapsed) = elapsed.to_std() {
if std_elapsed > invalidate_after {
tracing::trace!("memory cache out of date");
memory_cache.pop(route);
return Ok(None);
}
}
}

Expand Down

0 comments on commit 21fdecd

Please sign in to comment.