Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cliss and magcli versions #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump cliss and magcli versions #3

wants to merge 2 commits into from

Conversation

Miniland1333
Copy link

@Miniland1333 Miniland1333 commented Jan 23, 2021

@DiegoZoracKy I'm attempting to update all your dependencies that rely on cliss, though you have a lot of circular dependencies that make it hard for me to update them myself using PRs. While we could usually use the ^ caret to float the versions, this apparently doesn't work for versions below 1.x.x. Do you have a recommendation about how we should update all of these dependents?

Direct Dependents of Magcli

  • split-skip
  • data-query
  • image-data-uri
  • unpack-string
  • object-to-arguments (also circular dependency of cliss)
  • inspect-parameters-declaration (also circular dependency of cliss)
  • inspect-function (also circular dependency of inspect-property)
  • stringify-parameters (also circular dependency of inspect-property)
  • convert-excel-to-json

Secondary Dependents

inspect-property

Dependency flowchart

Note that both cliss and inspect-property are circular dependencies of magcli.
image

Possible solutions:

  • Enable dependabot on these repositories and merge in its automatic update PRs.
  • OR Update packages versions to >=1.0.0 and use ^ to float the dependencies
  • OR You go through all the dependencies and simultaneously push out new versions on all the repositories.

Let me know what you think!

@wmhartl
Copy link

wmhartl commented Feb 4, 2021

FWIW I'd say just bump to 1.0.0 and roll with it. Your code has been out there a while at this point.

I'd recommend just noting in your release notes why you're doing this and that there are no breaking changes (presuming that's the case) and you should be fine. React-router ran into a similar situation a while back, see how they did it: https://github.com/ReactTraining/react-router/releases/tag/v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants