Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add Integration Tests for Dice Commands(EXISTS, EXPIRE, EXPIREAT, EXPIRETIME) and Assertions Package #39

Merged

Conversation

RishabhC-137
Copy link
Contributor

@RishabhC-137 RishabhC-137 commented Oct 14, 2024

This pull request resolves several issues related to Dice command testing (Issue #29):
Added integration tests for Dice commands (EXISTS, EXPIRE, EXPIREAT, EXPIRETIME) in the following test files:

  • internal/tests/integration/commands/exists_test.go
  • internal/tests/integration/commands/expire_test.go
  • internal/tests/integration/commands/expireat_test.go
  • internal/tests/integration/commands/expiretime_test.go

Created a reusable assertions package to facilitate result validation across tests:

  • Includes the AssertResult function which verifies command execution outcomes using testify/assert.
  • Handles both expected error and non-error scenarios by asserting error presence and matching response/error messages.

…REAT, EXPIRETIME) and package for validation
@RishabhC-137
Copy link
Contributor Author

@lucifercr07 can you review this

@lucifercr07 lucifercr07 merged commit 9bc7f87 into DiceDB:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants