Fix/issue 33 #34
Closed
Fix/issue 33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucifercr07
requested changes
Oct 6, 2024
There was a problem hiding this comment.
@tarun-kavipurapu thanks for the fix, can you please add some tests around this.
|
@tarun-kavipurapu can you please check for |
|
@tarun-kavipurapu please resolve the conflicts. |
lucifercr07
requested changes
Oct 9, 2024
|
|
||
| // command2callback map | ||
| var command2callback = map[string]DiceDBCallback{ | ||
| "AUTH": renderSimpleString, |
There was a problem hiding this comment.
Can we make this other way around? Like group methods to commands list?
It'd reduce redundancy.
Something like below and add a finder on top of this
// Create hashsets (maps) for each command group
var simpleStringCommands = map[string]struct{}{
"AUTH": {}, "PING": {}, "SELECT": {},
"SET": {}, "RESTORE": {}, "FLUSHDB": {},
}
| strItem := fmt.Sprintf("%v", item) | ||
|
|
||
| // Properly format with double quotes | ||
| quoted := fmt.Sprintf("\"%q\"", strItem) |
There was a problem hiding this comment.
Can it just be single quotes? We're printing with 2 quotes? Is behaviour same as CLI?
dice > KEYS k*
1) ""k""
2) ""k1""
internal/db/dicedb.go
Outdated
|
Closing, as not required after recent SDK changes. Thanks a lot for the efforts @tarun-kavipurapu . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33