Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable list of commands from playground repositories #19

Closed
wants to merge 1 commit into from

Conversation

amankumarsingh77
Copy link

@amankumarsingh77 amankumarsingh77 commented Oct 2, 2024

This PR focuses on a blacklist feature that does not allow a set of commands to run in the DiceDB Playground project.
fixes DiceDB/dice#897
Changes

  1. Updated helpers.go:
    • Added a service layer to intercept and reject the request.
  2. Updated httpServer.go:
    • Implement the service layer and reject with a forbidden status

image

Testing

  • Verified that commands listed in the blacklist are properly rejected with the correct error message.
  • Confirmed that all other commands function as expected.

@lucifercr07
Copy link
Contributor

Since issue was assigned to another user and their PR is already created, it won't be good if we continue with this PR. Closing this PR, really thanks for your contribution.

@lucifercr07 lucifercr07 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable list of commands from playground repositories
2 participants