fix: reset prompt state upon exiting watch mode (issue #15) #17
Conversation
|
@arpitbbhayani Please review and let me know if there is a better way. |
cli/main.go
Outdated
| @@ -58,7 +58,8 @@ func Run(host string, port int) { | |||
| Fn: func(buf *prompt.Buffer) { | |||
| if dicedbClient.subscribed { | |||
| fmt.Println("Exiting watch mode.") | |||
There was a problem hiding this comment.
@arpitbbhayani I think this message log also should be moved to handleWatchModeExit method.
cli/main.go
Outdated
| c.subscribed = false | ||
| c.subType = "" |
There was a problem hiding this comment.
Would suggest this to be moved to case <-c.subCtx.Done():
The defer function in the watchCommand is not immediately getting executed when cancel() is called and meanwhile the subCtx.Done() channel will unblock and exit the loop. We can reset subscribed and subType immediately on cancel as part of exit itself.
There was a problem hiding this comment.
But, cancellation message is processed by this watchCommand goroutine asynchronously, right? So LivePrefix method can be executed even before we reset subscribed to false.
This state on which the LivePrefix depends should be reset synchronously.
Let me know in case I am missing something.
|
@vpsinghg can you please rebase the changes with master? |
…chronization for running LivePrefix after subscription state is reset
vpsinghg
force-pushed
the
fix/prompt_reset_on_exit_from_watch_mode
branch
from
b6c0e14 to
3dc3dd5
Compare
|
@arpitbbhayani I have rebased with master |
|
@arpitbbhayani Can you please review the changes? |
|
@vpsinghg please rebase once with master. |
This PR aims to fix issue #15 , where we need to enter one more time after exiting from watch mode to reset dicedb cli.