Support JSON.ARRINDEX #486 #1348
Conversation
|
Hey @JyotinderSingh @apoorvyadav1111 , requesting you to review this PR. |
| @@ -58,6 +58,8 @@ func runIntegrationTests(t *testing.T, exec *WebsocketCommandExecutor, conn *web | |||
| assert.True(t, result.(float64) <= out.(float64) && result.(float64) > 0, "Expected %v to be within 0 to %v", result, out) | |||
| case "json_equal": | |||
| assert.JSONEq(t, out.(string), result.(string)) | |||
| case "deep_equal": | |||
| assert.True(t, testutils.ArraysArePermutations(result.([]interface{}), out.([]interface{}))) | |||
There was a problem hiding this comment.
Can we try using ElementsMatch instead of a custom function, we are migrating from this function.
|
Hi @iamskp11, I reran the CI for the PR. Also, I would like to request to change the permutation function in other two files as well. Thanks |
|
Hi @iamskp11 , thanks for these changes. Could you please rebase the PR? I can merge once the CI checks are passed. |
|
@apoorvyadav1111 Pls do not merge. Getting some issues related to HTTP tests since cmd_meta.go is deleted in latest master. Will debug and fix today later. |
Hi @iamskp11, did you get a chance to address the issues? |
Hi @JyotinderSingh , thanks for reminding. |
Implements #486.